Re: [v2 PATCH 3/3] netlink: Use rhashtable walk interface in diag dump
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-08-19 16:39:10
On Fri, Aug 19, 2016 at 06:32:37PM +0200, Thomas Graf wrote:
On 08/19/16 at 04:21pm, Herbert Xu wrote:quoted
This patch converts the diag dumping code to use the rhashtable walk code instead of going through rhashtable by hand. The lock nl_table_lock is now only taken while we process the multicast list as it's not needed for the rhashtable walk. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>LGTM. Curious, what did you use to test this? I've been struggling to find a good test case.
ss -A netlink Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt