Re: [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init

On Fri, Aug 19, 2016 at 06:25:04PM +0200, Thomas Graf wrote:

On 08/18/16 at 04:50pm, Herbert Xu wrote:

quoted

+/* Obsolete function, do not use in new code. */
+static inline int rhashtable_walk_init(struct rhashtable *ht,
+				       struct rhashtable_iter *iter, gfp_t gfp)
+{
+	rhashtable_walk_enter(ht, iter);
+	return 0;
+}

Converting the 5 users of rhashtable_walk_init() looks very straight
forward, any reason to keep this around?

It is easy but it's needless churn, especially since we've just
converted all of them the other way.

Feel free to do a patch on top of this to get rid of them.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt