On 26.07.16 17:26, Grygorii Strashko wrote:

+ CC: Ivan

On 07/26/2016 05:09 PM, Grygorii Strashko wrote:

quoted

On 07/26/2016 03:57 AM, David Miller wrote:

quoted

From: Uwe Kleine-König <redacted>
Date: Mon, 25 Jul 2016 11:54:45 +0200

quoted

Such a big dump of register values is hardly useful on a production
system.

Another downside of the now removed functions is that calling
emac_dump_regs resulted in at least 87 calls to dev_info while holding a
spinlock and having irqs off which is a big source of latency.

Signed-off-by: Uwe Kleine-König <redacted>

Applied.

:( To be honest I was really enjoyed using cpdma_ctlr_dump()
for debug purposed during the past few weeks in cpsw where I've added
calls to this func manually. And I even thinking about adding debug_fs
entry for the same :(

Pretty fast merge :(

At least, partly, for channel stats, for cpsw, I can use ethtool.
But ctrl_dump()... the function would be better to leave, redundant calls can be
removed from davinci_emac.

quoted

-- 
Regards,
Ivan Khoronzhuk