Thread (5 messages) 5 messages, 4 authors, 2016-07-26

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2016-07-26 14:09:33
Also in: linux-omap

On 07/26/2016 03:57 AM, David Miller wrote:
From: Uwe Kleine-König <redacted>
Date: Mon, 25 Jul 2016 11:54:45 +0200
quoted
Such a big dump of register values is hardly useful on a production
system.

Another downside of the now removed functions is that calling
emac_dump_regs resulted in at least 87 calls to dev_info while holding a
spinlock and having irqs off which is a big source of latency.

Signed-off-by: Uwe Kleine-König <redacted>
Applied.
:( To be honest I was really enjoyed using cpdma_ctlr_dump()
for debug purposed during the past few weeks in cpsw where I've added 
calls to this func manually. And I even thinking about adding debug_fs 
entry for the same :(

Pretty fast merge :(


-- 
regards,
-grygorii
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help