Re: [PATCH v10 00/12] Add driver bpf hook for early packet drop and forwarding

On Wed, Jul 20, 2016 at 12:18:49PM +0300, Tariq Toukan wrote:

On 20/07/2016 8:09 AM, David Miller wrote:

quoted

From: Brenden Blanco <redacted>
Date: Tue, 19 Jul 2016 12:16:45 -0700

quoted

This patch set introduces new infrastructure for programmatically
processing packets in the earliest stages of rx, as part of an effort
others are calling eXpress Data Path (XDP) [1]. Start this effort by
introducing a new bpf program type for early packet filtering, before
even an skb has been allocated.

Extend on this with the ability to modify packet data and send back out
on the same port.

Series applied, thanks.

Hi Dave,

The series causes compilation errors in our driver (and warnings).
Please revert it.

My bad. The kbuild robot caught it as well. As an alternative to revert,
I can also send a patch to add the necessary inline stub.

*23:08:37*drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In
function 'mlx4_xdp_set':

*23:08:37*drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2566:4:
error: implicit declaration of function 'bpf_prog_add'
[-Werror=implicit-function-declaration]

*23:08:37*    prog = bpf_prog_add(prog, priv->rx_ring_num - 1);

*23:08:37*    ^

*23:08:37*  CC [M]  drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.o

*23:08:37*drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2566:9:
warning: assignment makes pointer from integer without a cast
[enabled by default]

*23:08:37*    prog = bpf_prog_add(prog, priv->rx_ring_num - 1);

*23:08:37*         ^

*23:08:37*drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2592:8:
warning: assignment makes pointer from integer without a cast
[enabled by default]

*23:08:37*   prog = bpf_prog_add(prog, priv->rx_ring_num - 1);

*23:08:37*        ^

*23:08:37*cc1: some warnings being treated as errors

*23:08:37*make[7]: ***
[drivers/net/ethernet/mellanox/mlx4/en_netdev.o] Error 1

*23:08:37*make[7]: *** Waiting for unfinished jobs....

*23:08:37*  CC      drivers/tty/serial/8250/8250_pnp.o