Re: [PATCH net-next v2 02/10] net/ncsi: NCSI command packet handler

On Mon, Jul 18, 2016 at 10:15:21AM +1000, Gavin Shan wrote:

On Fri, Jul 15, 2016 at 10:08:23PM +0800, kbuild test robot wrote:

quoted

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Gavin-Shan/NCSI-Support/20160715-190549
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
       # save the attached .config to linux build tree
       make ARCH=i386 

All error/warnings (new ones prefixed by >>):

  In file included from include/linux/swab.h:4:0,
                   from include/uapi/linux/byteorder/little_endian.h:12,
                   from include/linux/byteorder/little_endian.h:4,
                   from arch/x86/include/uapi/asm/byteorder.h:4,
                   from include/asm-generic/bitops/le.h:5,
                   from arch/x86/include/asm/bitops.h:504,
                   from include/linux/bitops.h:36,
                   from include/linux/kernel.h:10,
                   from include/linux/list.h:8,
                   from include/linux/module.h:9,
                   from net/ncsi/ncsi-cmd.c:10:
  net/ncsi/ncsi-cmd.c: In function 'ncsi_alloc_command':

quoted

quoted

net/ncsi/ncsi-cmd.c:301:24: error: 'ETH_P_NCSI' undeclared (first use in this function)

    skb->protocol = htons(ETH_P_NCSI);
                          ^

The ETH_P_NCSI definition in include/uapi/linux/if_ether.h was missed from this series. I
will fix it in next respin to address comments received from this series.

I will send followup v3 shortly since David marked this series as "change requested"
in patchwork.

Thanks,
Gavin