Thread (10 messages) flat view 10 messages, 3 authors, 2016-07-14

Re: [PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

From: Aaron Conole <hidden>
Date: 2016-07-14 18:01:44
Also in: netfilter-devel

Pablo Neira Ayuso [off-list ref] writes:
On Tue, Jul 12, 2016 at 11:32:19AM -0400, Aaron Conole wrote:
quoted
+/* recursively invokes nf_hook_slow (again), skipping already-called
+ * hooks (< NF_BR_PRI_BRNF).
+ *
+ * Called with rcu read lock held.
+ */
+int br_nf_hook_thresh(unsigned int hook, struct net *net,
+		      struct sock *sk, struct sk_buff *skb,
+		      struct net_device *indev,
+		      struct net_device *outdev,
+		      int (*okfn)(struct net *, struct sock *,
+				  struct sk_buf *))
                                         ^^^^^^

This doesn't compile. Please, make sure patches compile independently
so we make sure git bisectability doesn't break. Thanks.
Okay, I will make sure to do this for all the patches.  Apologies.

Thanks for the review.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help