Re: [PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held
From: Florian Westphal <fw@strlen.de>
Date: 2016-07-14 17:42:13
Also in:
netfilter-devel
Pablo Neira Ayuso [off-list ref] wrote:
quoted
diff --git a/net/bridge/netfilter/ebt_redirect.c b/net/bridge/netfilter/ebt_redirect.c index 20396499..2e7c4f9 100644 --- a/net/bridge/netfilter/ebt_redirect.c +++ b/net/bridge/netfilter/ebt_redirect.c@@ -24,7 +24,7 @@ ebt_redirect_tg(struct sk_buff *skb, const struct xt_action_param *par) return EBT_DROP; if (par->hooknum != NF_BR_BROUTING) - /* rcu_read_lock()ed by nf_hook_slow */ + /* rcu_read_lock()ed by nf_hook_thresh */Why are all these comments being renamed in this patch? This patch description doesn't say anything about this.
Aaron, I'm sorry about this. I suggest to do this renaming in a different patch, i.e. keep the rcu_read_lock in nf_hook_slow in this patch.