Re: [PATCH net-next 2/4] net/mlx4: Preparation for VST QinQ

On 10/07/2016 7:00 PM, Tariq Toukan wrote:

quoted

quoted

Add func capability vlan_offload_disable to disable all vlan HW
acceleration on VF while the VF is set to VST QinQ mode.

this part (above two lines) is code running in the VF Eth driver, correct? if this is indeed the case, break the patch to two (1) PF core driver  (2) VF core/EN driver

What happens if the VF doesn't work as you expect? e.g the PF runs your code and the VF driver is unpatched?

Good point, currently if the administrator sets the configuration then it just silently not fail. We will use a mechanism that prevents this.

* silently fails