RE: [PATCH net-next 4/4] net/mlx4_core: Add an option to configure SVLAN TPID

On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan [off-list ref] wrote:

quoted

From: Moshe Shemesh <redacted>

Expose mlx4_config_svlan_tpid, that checks for feature support in 
device capabilities and sets the Service Tag TPID accordingly.

I Googled for service tag TPID and I understand this is what we can vlan protcol, correct? any reason to >call it differently?

No, it is not the vlan protocol.
It is the ethertype used on the external vlan and the correct term is TPID.

dead code? I don't see any invocation of this helper on the patch, if it's on earlier patches of the series it means you broke bisection...

I will recheck about that.

Regards,
Moshe.