Re: [PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match

From
Julian Calaby <hidden>
Date
2016-06-01 04:23:34
Also in
linux-wireless, lkml
Reply to
Javier Martinez Canillas, 2016-05-27
Hi All,

On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
[off-list ref] wrote:
The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT
binding document lists the possible compatible strings that a SDIO child
node can have, so the driver checks if the defined in the node matches.

But the error message when that's not the case is misleading, so change
for one that makes clear what the error really is. Also, returning a -1
as errno code is not correct since that's -EPERM. A -EINVAL seems to be
a more appropriate one.

Signed-off-by: Javier Martinez Canillas <redacted>
This looks sensible to me.

Reviewed-by: Julian Calaby <redacted>
quoted hunk ↗ jump to hunk

---

 drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Thread (23 messages) 23 messages, 5 authors, last reply 2016-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help