Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

On 06/16/2016 09:55 PM, Sergei Shtylyov wrote:

quoted

By default, mdiobus_alloc() sets the PHY's to polling mode, but a

   Rather "PHYs".

quoted

pointer size memcpy means that couple IRQs (depending

   Could be more words on this line, it's broken too early, I think.

quoted

on 32-bit or 64-bit kernels) end up being overwritten with
a value of 0. This means that PHY_POLL is disabled and results
in unpredictable behavior depending on the PHYs location on the mdio

   Contrariwise, "PHY's" here. And it's MDIO.

quoted

bus. Remove that memcpy and the now unused phy_irq member to force
SMSC911x PHY's into polling mode 100% of the time.

Signed-off-by: Jeremy Linton <redacted>

Acked-by: Sergei Shtylyov <redacted>

    I was going to add the following too but just forgot:

Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")

[...]

MBR, Sergei