Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-16

Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-06-16 16:33:39

On Thu, Jun 16, 2016 at 10:54:30AM -0500, Jeremy Linton wrote:
By default, mdiobus_alloc() sets the PHY's to polling mode, but a
pointer size memcpy means that couple IRQs (depending
on 32-bit or 64-bit kernels) end up being overwritten with
a value of 0. This means that PHY_POLL is disabled and results
in unpredictable behavior depending on the PHYs location on the mdio
bus. Remove that memcpy and the now unused phy_irq member to force
SMSC911x PHY's into polling mode 100% of the time.

Signed-off-by: Jeremy Linton <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help