Re: [PATCH net-next] nfnetlink_queue: enable PID info retrieval
From: Eric Dumazet <hidden>
Date: 2016-06-09 21:17:14
Also in:
netfilter-devel
On Thu, 2016-06-09 at 23:50 +0300, Saeed Mahameed wrote:
From: Matthew Finlay <redacted>
quoted hunk ↗ jump to hunk
diff --git a/net/socket.c b/net/socket.c index a1bd161..67de200 100644 --- a/net/socket.c +++ b/net/socket.c@@ -382,6 +382,7 @@ struct file *sock_alloc_file(struct socket *sock, int flags, const char *dname) } sock->file = file; + file->f_owner.sock_pid = find_get_pid(task_pid_nr(current)); file->f_flags = O_RDWR | (flags & O_NONBLOCK); file->private_data = sock; return file;
Wow, that is a serious memory leak weapon (of struct pid) Why don't you store the pid value, instead of a pointer ?