Thread (10 messages) flat view 10 messages, 3 authors, 2016-06-08

Re: [PATCH net-next v4 5/6] net: dsa: Initialize CPU port ethtool ops per tree

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-06-08 15:09:39

On Tue, Jun 07, 2016 at 04:32:42PM -0700, Florian Fainelli wrote:
Now that we can properly support multiple distinct trees in the system,
using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered
as soon as the second switch tree gets probed, and we don't want that.

We need to move this to be dynamically allocated, and since we can't
really be comparing addresses anymore to determine first time
initialization versus any other times, just move this to dsa.c and
dsa2.c where the remainder of the dst/ds initialization happens.

The operations teardown restores the master netdev's ethtool_ops to its
original ethtool_ops pointer (typically within the Ethernet driver)

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help