Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF
From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2016-06-03 22:20:09
On 06/03/2016 11:49 PM, Helge Deller wrote:
Commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF option.
Signed-off-by: Helge Deller <deller@gmx.de>LGTM, thanks! Acked-by: Daniel Borkmann <daniel@iogearbox.net> [ Cc Willem: I believe we also need something similar for PACKET_FANOUT_DATA when PACKET_FANOUT_CBPF is requested since we have the same issue with the pointer in struct sock_fprog there, too. ]
quoted hunk ↗ jump to hunk
diff --git a/net/compat.c b/net/compat.c index 5cfd26a..1373947 100644 --- a/net/compat.c +++ b/net/compat.c@@ -354,7 +354,8 @@ static int do_set_sock_timeout(struct socket *sock, int level, static int compat_sock_setsockopt(struct socket *sock, int level, int optname, char __user *optval, unsigned int optlen) { - if (optname == SO_ATTACH_FILTER) + if (optname == SO_ATTACH_FILTER || + optname == SO_ATTACH_REUSEPORT_CBPF) return do_set_attach_filter(sock, level, optname, optval, optlen); if (optname == SO_RCVTIMEO || optname == SO_SNDTIMEO)