Thread (29 messages) flat view 29 messages, 2 authors, 2016-05-07

Re: [PATCH net-next 12/21] net: dsa: mv88e6xxx: factorize switch reset

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-05-06 22:28:01
Also in: lkml

quoted hunk ↗ jump to hunk
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index dbbda4e..b744ed5 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2551,6 +2551,68 @@ restore_page_0:
 	return ret;
 }
 
+static int _mv88e6xxx_switch_reset(struct mv88e6xxx_priv_state *ps)
+{
You missed removing the _ prefix.

Thanks for removing the others. With so much less noise, it is easier
to review the patches.

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help