Re: [PATCH net-next 06/21] net: dsa: mv88e6xxx: factorize MAC address setting
From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-05-06 22:23:23
Also in:
lkml
quoted hunk ↗ jump to hunk
@@ -378,6 +385,7 @@ enum mv88e6xxx_cap { #define MV88E6XXX_FLAG_EEPROM BIT(MV88E6XXX_CAP_EEPROM) #define MV88E6XXX_FLAG_PPU BIT(MV88E6XXX_CAP_PPU) #define MV88E6XXX_FLAG_SMI_PHY BIT(MV88E6XXX_CAP_SMI_PHY) +#define MV88E6XXX_FLAG_SWITCH_MAC BIT(MV88E6XXX_CAP_SWITCH_MAC_WOL_WOF) #define MV88E6XXX_FLAG_TEMP BIT(MV88E6XXX_CAP_TEMP) #define MV88E6XXX_FLAG_TEMP_LIMIT BIT(MV88E6XXX_CAP_TEMP_LIMIT)
There is a general pattern here that the flag has a name derived from the capability. Except you dropped the WOL_WOF here. It would probably be better to not have WOL_WOF at all. Andrew