Thread (33 messages) 33 messages, 3 authors, 2016-04-07

RE: [PATCH net-next V3 02/16] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

flat view
STALE3844d REVIEWED: 1 (0M)

From: Fugang Duan <hidden>
Date: 2016-04-06 09:10:30
Also in: linux-arm-kernel

1 review trailer.

From: Troy Kisky <redacted> Sent: Wednesday, April 06, 2016 10:26 AM
quoted hunk ↗ jump to hunk
To: netdev@vger.kernel.org; davem@davemloft.net; Fugang Duan
[off-list ref]; lznuaa@gmail.com
Cc: Fabio Estevam <redacted>; l.stach@pengutronix.de;
andrew@lunn.ch; tremyfr@gmail.com; gerg@uclinux.org; linux-arm-
kernel@lists.infradead.org; johannes@sipsolutions.net;
stillcompiling@gmail.com; sergei.shtylyov@cogentembedded.com;
arnd@arndb.de; Troy Kisky [off-list ref]
Subject: [PATCH net-next V3 02/16] net: fec: remove unused interrupt
FEC_ENET_TS_TIMER

FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no need
to enable it.

Signed-off-by: Troy Kisky <redacted>

---
v3: New patch

Frank Li said "TS_TIMER should never be triggered."
when discussing another patch.
---
 drivers/net/ethernet/freescale/fec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net/ethernet/freescale/fec.h
index 195122e..6dd0ba8 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -374,8 +374,8 @@ struct bufdesc_ex {
 #define FEC_ENET_TS_AVAIL       ((uint)0x00010000)
 #define FEC_ENET_TS_TIMER       ((uint)0x00008000)

-#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII
| FEC_ENET_TS_TIMER)
-#define FEC_NAPI_IMASK	(FEC_ENET_MII | FEC_ENET_TS_TIMER)
+#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII)
+#define FEC_NAPI_IMASK	FEC_ENET_MII
 #define FEC_RX_DISABLED_IMASK (FEC_DEFAULT_IMASK & (~FEC_ENET_RXF))

 /* ENET interrupt coalescing macro define */
--
2.5.0
Acked-by: Fugang Duan <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help