Re: [PATCH net-next V2 04/10] net/act_skbedit: Utility functions for mark action

On Thu, Mar 03, 2016 at 09:48:40AM -0800, Cong Wang wrote:

On Thu, Mar 3, 2016 at 6:55 AM, Amir Vadai [off-list ref] wrote:

quoted

+static inline bool is_tcf_skbedit_mark(const struct tc_action *a)
+{
+#ifdef CONFIG_NET_CLS_ACT
+       if (a->ops && a->ops->type == TCA_ACT_SKBEDIT)
+               return to_skbedit(a)->flags == SKBEDIT_F_MARK;

You mean to_skbedit(a)->flags & SKBEDIT_F_MARK ?

I will add a comment in v3 - it is on purpose. The function return true
iff the function is mark - other actions should not be offloaded.