On Thu, Mar 3, 2016 at 6:55 AM, Amir Vadai [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Introduce the macros tc_no_actions and tc_for_each_action to make code
clearer.
Suggested-by: Jiri Pirko <redacted>
Signed-off-by: Amir Vadai <redacted>
---
include/net/act_api.h | 21 ++++++++++++++++-----
include/net/tc_act/tc_gact.h | 4 ++--
2 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/include/net/act_api.h b/include/net/act_api.h
index 342be6c..2a19fe1 100644
--- a/include/net/act_api.h
+++ b/include/net/act_api.h
@@ -78,11 +78,6 @@ static inline void tcf_lastuse_update(struct tcf_t *tm)
tm->lastuse = now;
}
-#ifdef CONFIG_NET_CLS_ACT
-
-#define ACT_P_CREATED 1
-#define ACT_P_DELETED 1
-
struct tc_action {
void *priv;
const struct tc_action_ops *ops;@@ -92,6 +87,11 @@ struct tc_action {
struct tcf_hashinfo *hinfo;
};
You also expose struct tc_action out of CONFIG_NET_CLS_ACT,
which you never mention in your changelog at all.
So why?