Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

On 02/09/2016 02:38 PM, Arnd Bergmann wrote:

On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:

quoted

The descriptors are usable by different drivers, one driver may use it as 
buf ptr/ len, other for something else. So they should remain as generic
and it is up to individual drivers to use it in whatever way it requires.
My suggestion is to rename pad field in struct knav_dma_desc to sw_data
to avoid confusion. i.e 

+       __le32  pad[4];

to 

+       __le32  sw_data[4];

If the hardware doesn't access them, they can probably just be u32
and not do any byte swapping.

Ok. Will do in v1

	Arnd

-- 
Murali Karicheri
Linux Kernel, Keystone