Thread (14 messages) flat view 14 messages, 5 authors, 2016-02-18

Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-02-09 19:38:38
Also in: lkml

On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
The descriptors are usable by different drivers, one driver may use it as 
buf ptr/ len, other for something else. So they should remain as generic
and it is up to individual drivers to use it in whatever way it requires.
My suggestion is to rename pad field in struct knav_dma_desc to sw_data
to avoid confusion. i.e 

+       __le32  pad[4];

to 

+       __le32  sw_data[4];
If the hardware doesn't access them, they can probably just be u32
and not do any byte swapping.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help