Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions
From: David Miller <davem@davemloft.net>
Date: 2016-02-22 19:10:18
From: <Woojung.Huh@microchip.com> Date: Mon, 22 Feb 2016 18:28:18 +0000
quoted
This is incorrect; you should always return the manual settings (fc_request_control flags) here. If autonegotiation is enabled then your get_settings function will return the actual pause flags.What do you mean "return actual pause flags" when autoneg is enabled? Pause flags set by (or default) advertise flag?
It means what was negotiated by autonegotiation, and is actually in use. Otherwise, how can the user find out what was negotiated?