RE: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions
From: <Woojung.Huh@microchip.com>
Date: 2016-02-22 18:28:20
This is incorrect; you should always return the manual settings (fc_request_control flags) here. If autonegotiation is enabled then your get_settings function will return the actual pause flags.
What do you mean "return actual pause flags" when autoneg is enabled? Pause flags set by (or default) advertise flag? Thanks.