[PATCHv3 net 1/5] nfp: return error if MTU change fails
From: Jakub Kicinski <hidden>
Date: 2016-02-18 20:38:20
Subsystem:
netronome ethernet drivers, networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
When reopening device fails after MTU change, let the userspace know. MTU remains changed even though error is returned, this is what all ethernet devices are doing. Signed-off-by: Jakub Kicinski <redacted> Reviewed-by: Rolf Neugebauer <redacted> --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 43c618bafdb6..006d9600240f 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c@@ -1911,6 +1911,7 @@ static void nfp_net_set_rx_mode(struct net_device *netdev) static int nfp_net_change_mtu(struct net_device *netdev, int new_mtu) { struct nfp_net *nn = netdev_priv(netdev); + int ret = 0; u32 tmp; nn_dbg(nn, "New MTU = %d\n", new_mtu);
@@ -1929,10 +1930,10 @@ static int nfp_net_change_mtu(struct net_device *netdev, int new_mtu) /* restart if running */ if (netif_running(netdev)) { nfp_net_netdev_close(netdev); - nfp_net_netdev_open(netdev); + ret = nfp_net_netdev_open(netdev); } - return 0; + return ret; } static struct rtnl_link_stats64 *nfp_net_stat64(struct net_device *netdev,
--
1.9.1