[PATCHv3 net 2/5] nfp: free buffers before changing MTU
From: Jakub Kicinski <hidden>
Date: 2016-02-18 20:38:21
Subsystem:
netronome ethernet drivers, networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
For freeing DMA buffers we depend on nfp_net.fl_bufsz having the same value as during allocation therefore in .ndo_change_mtu we must first free the buffers and then change the setting. Signed-off-by: Jakub Kicinski <redacted> Reviewed-by: Rolf Neugebauer <redacted> --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 006d9600240f..b381682de3d6 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c@@ -1921,17 +1921,17 @@ static int nfp_net_change_mtu(struct net_device *netdev, int new_mtu) return -EINVAL; } + if (netif_running(netdev)) + nfp_net_netdev_close(netdev); + netdev->mtu = new_mtu; /* Freelist buffer size rounded up to the nearest 1K */ tmp = new_mtu + ETH_HLEN + VLAN_HLEN + NFP_NET_MAX_PREPEND; nn->fl_bufsz = roundup(tmp, 1024); - /* restart if running */ - if (netif_running(netdev)) { - nfp_net_netdev_close(netdev); + if (netif_running(netdev)) ret = nfp_net_netdev_open(netdev); - } return ret; }
--
1.9.1