On 16-02-16 12:20 PM, Jiri Pirko wrote:

Tue, Feb 16, 2016 at 07:01:25AM CET, john.fastabend@gmail.com wrote:

quoted

This patch allows netdev drivers to consume cls_u32 offloads via
the ndo_setup_tc ndo op.

This works aligns with how network drivers have been doing qdisc
offloads for mqprio.

Signed-off-by: John Fastabend <redacted>

<snip>

quoted

+struct tc_cls_u32_hnode {
+	u32 handle;
+	u32 prio;
+	unsigned int divisor;
+};
+
+enum {

Please name enum and ...

quoted

+	TC_CLSU32_NEW_KNODE,
+	TC_CLSU32_REPLACE_KNODE,
+	TC_CLSU32_DELETE_KNODE,
+	TC_CLSU32_NEW_HNODE,
+	TC_CLSU32_REPLACE_HNODE,
+	TC_CLSU32_DELETE_HNODE,
+};
+
+struct tc_cls_u32_offload {
+	/* knode values */
+	int command;

... use it here instead of "int"

Yep thanks. I'll go ahead and do this now.