Re: [net-next PATCH v2 3/8] net: sched: add cls_u32 offload hooks for netdevs
From: Jiri Pirko <jiri@resnulli.us>
Date: 2016-02-16 20:20:51
Tue, Feb 16, 2016 at 07:01:25AM CET, john.fastabend@gmail.com wrote:
This patch allows netdev drivers to consume cls_u32 offloads via the ndo_setup_tc ndo op. This works aligns with how network drivers have been doing qdisc offloads for mqprio. Signed-off-by: John Fastabend <redacted>
<snip>
+struct tc_cls_u32_hnode {
+ u32 handle;
+ u32 prio;
+ unsigned int divisor;
+};
+
+enum {Please name enum and ...
+ TC_CLSU32_NEW_KNODE,
+ TC_CLSU32_REPLACE_KNODE,
+ TC_CLSU32_DELETE_KNODE,
+ TC_CLSU32_NEW_HNODE,
+ TC_CLSU32_REPLACE_HNODE,
+ TC_CLSU32_DELETE_HNODE,
+};
+
+struct tc_cls_u32_offload {
+ /* knode values */
+ int command;... use it here instead of "int"