Re: [PATCH net-next 1/4] net: add event_list to struct net and provide utility functions

On Tue, Feb 2, 2016 at 12:01 PM, Julian Anastasov [off-list ref] wrote:

quoted

+#ifdef CONFIG_NET_NS
+static inline void net_add_event_list(struct list_head *head, struct net *net)
+{
+     if (!list_empty(&net->event_list))

        Above check looks inverted, it works may be
because INIT_LIST_HEAD(&net->event_list) is missing.

quoted

+             list_add_tail(&net->event_list, head);
+}
+

Thanks for catching this! I ran my benchmark again with the corrected check
and I still get the same benefits with respect to rtnl_lock hold time.

Salam