Re: [net-next PATCH 07/11] net: introduce napi_alloc_skb_hint() for more use-cases
From: kbuild test robot <hidden>
Date: 2016-02-02 22:30:19
Hi Jesper, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/net-mitigating-kmem_cache-slowpath-and-BoF-discussion-patches/20160203-051706 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/skbuff.h:922: warning: No description found for parameter 'sk'
quoted
net/core/skbuff.c:482: warning: No description found for parameter 'bulk_hint'
net/core/gen_stats.c:155: warning: No description found for parameter 'cpu'
net/core/gen_estimator.c:212: warning: No description found for parameter 'cpu_bstats'
net/core/gen_estimator.c:303: warning: No description found for parameter 'cpu_bstats'
net/core/dev.c:6450: warning: No description found for parameter 'len'
include/linux/netdevice.h:1321: warning: Enum value 'IFF_XMIT_DST_RELEASE_PERM' not described in enum 'netdev_priv_flags'
include/linux/netdevice.h:1321: warning: Enum value 'IFF_IPVLAN_MASTER' not described in enum 'netdev_priv_flags'
include/linux/netdevice.h:1321: warning: Enum value 'IFF_IPVLAN_SLAVE' not described in enum 'netdev_priv_flags'
include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_all'
include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_specific'
vim +/bulk_hint +482 net/core/skbuff.c
^1da177e Linus Torvalds 2005-04-16 466
fd11a83d Alexander Duyck 2014-12-09 467 /**
fd11a83d Alexander Duyck 2014-12-09 468 * __napi_alloc_skb - allocate skbuff for rx in a specific NAPI instance
fd11a83d Alexander Duyck 2014-12-09 469 * @napi: napi instance this buffer was allocated for
d7499160 Masanari Iida 2015-08-24 470 * @len: length to allocate
fd11a83d Alexander Duyck 2014-12-09 471 * @gfp_mask: get_free_pages mask, passed to alloc_skb and alloc_pages
fd11a83d Alexander Duyck 2014-12-09 472 *
fd11a83d Alexander Duyck 2014-12-09 473 * Allocate a new sk_buff for use in NAPI receive. This buffer will
fd11a83d Alexander Duyck 2014-12-09 474 * attempt to allocate the head from a special reserved region used
fd11a83d Alexander Duyck 2014-12-09 475 * only for NAPI Rx allocation. By doing this we can save several
fd11a83d Alexander Duyck 2014-12-09 476 * CPU cycles by avoiding having to disable and re-enable IRQs.
fd11a83d Alexander Duyck 2014-12-09 477 *
fd11a83d Alexander Duyck 2014-12-09 478 * %NULL is returned if there is no free memory.
fd11a83d Alexander Duyck 2014-12-09 479 */
9451980a Alexander Duyck 2015-05-06 480 struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len,
c24f01ac Jesper Dangaard Brouer 2016-02-02 481 unsigned int bulk_hint, gfp_t gfp_mask)
fd11a83d Alexander Duyck 2014-12-09 @482 {
1ec46e92 Jesper Dangaard Brouer 2016-02-02 483 struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
c24f01ac Jesper Dangaard Brouer 2016-02-02 484 unsigned int bulk_sz = min(bulk_hint, NAPI_SKB_CACHE_SIZE);
fc755a89 Jesper Dangaard Brouer 2016-02-02 485 struct skb_shared_info *shinfo;
fd11a83d Alexander Duyck 2014-12-09 486 struct sk_buff *skb;
9451980a Alexander Duyck 2015-05-06 487 void *data;
fd11a83d Alexander Duyck 2014-12-09 488
9451980a Alexander Duyck 2015-05-06 489 len += NET_SKB_PAD + NET_IP_ALIGN;
9451980a Alexander Duyck 2015-05-06 490
:::::: The code at line 482 was first introduced by commit
:::::: fd11a83dd3630ec6a60f8a702446532c5c7e1991 net: Pull out core bits of __netdev_alloc_skb and add __napi_alloc_skb
:::::: TO: Alexander Duyck [off-list ref]
:::::: CC: David S. Miller [off-list ref]
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation Attachments
- .config.gz [application/octet-stream] 6229 bytes