RE: gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection

-----Original Message-----
From: SF Markus Elfring [mailto:elfring@users.sourceforge.net]
Sent: Friday, January 15, 2016 7:33 PM
To: Joe Perches <joe@perches.com>; netdev@vger.kernel.org
Cc: Claudiu Manoil <redacted>; LKML <linux-
kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org; Julia Lawall
[off-list ref]
Subject: Re: gianfar: Less function calls in gfar_ethflow_to_filer_table() after
error detection

quoted

quoted

quoted

	local_rqfpr = kmalloc_array(2 * (MAX_FILER_IDX + 1),
				    sizeof(unsigned int), GFP_KERNEL);
	if (!local_rqfpr)
		goto err;

	local_rqfcr = &local_rqfpr[MAX_FILER_IDX + 1];

Do you suggest to use only one array (instead of two as before) here?

That's a possibility.

Thanks for your clarification.

quoted

If, as your title suggests, you really want fewer function calls,

I am unsure at the moment if more changes will make sense in
this function implementation.

quoted

(which as far as I saw, you didn't do)

Is my wording "after error detection" insufficient eventually?

quoted

that could be a mechanism to remove both an allocation and a free.

Would any more software developers or source code reviewers like
to share their opinions in such a direction?

Hi,
This kind of fixes are net-next stuff at best, no need to push them into
the net tree right now.
So please wait with these submissions until net-next re-opens at least.
Thanks.