Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table()
From: SF Markus Elfring <hidden>
Date: 2016-01-15 11:35:00
Also in:
kernel-janitors, lkml
quoted
+++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c@@ -768,12 +768,12 @@ static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow) static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u64 class) { - unsigned int last_rule_idx = priv->cur_filer_idx; + unsigned int last_rule_idx;This is a write only variable. We can just remove it.
Can a static source code analysis tool like the software "http://smatch.sourceforge.net/" detect that such a variable is not read by this function implementation so far? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/gianfar_ethtool.c?id=b75ec3af27bf011a760e2f44eb25a99b6fbb0fb3#n850 Does this place indicate an unwanted value assignment as a leftover, or are there any other actions missing? Regards, Markus