Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()
From: Dan Carpenter <hidden>
Date: 2016-01-04 11:48:58
Also in:
kernel-janitors, linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2016-01-04 · Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() · Dan Carpenter <hidden>
- 2016-01-04 · Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() · Bjørn Mork <bjorn@mork.no>
On Mon, Jan 04, 2016 at 11:44:15AM +0100, SF Markus Elfring wrote:
quoted
Please stop sending cleanup patches, Markus. Just send fixes.How often will source code clean-up fix something? May I resend a consistent patch series for the source file "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future?
If you were sending checkpatch.pl fixes that would be easier to deal with but you are sending hundreds of "controversial" cleanups. They are controversial in the sense that they don't fix anything against official kernel style and they go against the author's original intention. I tend to agree that useless initializers are bad and disable GCCs uninitialized variable warnings but just because I agree with you doesn't make it official kernel style. It's slightly rude to go against the author's intention. regards, dan carpenter