net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt()
From: SF Markus Elfring <hidden>
Date: 2016-01-02 15:12:38
Also in:
kernel-janitors, linux-wireless, lkml
From: SF Markus Elfring <hidden>
Date: 2016-01-02 15:12:38
Also in:
kernel-janitors, linux-wireless, lkml
Hello, I have taken another look at the implementation of the function "rsi_send_mgmt_pkt". https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/wireless/rsi/rsi_91x_pkt.c?id=e8c58e7a5a106c3d557fccd01cd4d1128f9bab38#n114 I find the following statement combination interesting there. … u8 vap_id = 0; … msg[7] |= cpu_to_le16(vap_id << 8); … I would appreciate a further clarification. Does a shift operation for a variable which contains zero indicate an open issue? Regards, Markus