Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps
From: Nicolas Ferre <hidden>
Date: 2015-12-08 16:22:34
Also in:
linux-devicetree, lkml
Le 08/12/2015 16:00, Arnd Bergmann a écrit :
On Tuesday 08 December 2015 14:52:05 Neil Armstrong wrote:quoted
Add 1:1 mapping of software defines caps parsing from DT in case the generic macb compatible form is used. These properties will provide support for futures implementations only defined from DT without need to update the driver code to support new variants. Signed-off-by: Neil Armstrong <redacted>Translating the Linux implementation specific configuration into DT properties directly is usually not the best way. Could we instead have a lookup table by compatible string to set the flags? It seems that there are lots of different flags but only a couple of different users of this IP block. Also, the fact that you are now adding yet another quirk tells me that the set you define today is unlikely to cover all the future requirements.
This is basically what I told Neil in my previous email. I understand you point Neil, but I don't find it makes sense and Arnd described it better that I did. So please find a proper compatibility string and simply use it. What about: "cdns,the_name_of_the_product_that_first_implemented_this_no_usrio_special_case-gem"? Bye, -- Nicolas Ferre