Thread (33 messages) flat view 33 messages, 6 authors, 2016-01-07

Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms

From: Josh Cartwright <hidden>
Date: 2015-12-07 19:32:28
Also in: linux-devicetree, lkml

On Mon, Dec 07, 2015 at 11:58:33AM +0100, Neil Armstrong wrote:
On some platforms, the macb integration does not use the USRIO
register to configure the (R)MII port and clocks.
When the register is not implemented and the MACB error signal
is connected to the bus error, reading or writing to the USRIO
register can trigger some Imprecise External Aborts on ARM platforms.
---
Does this make sense to even be a separate bool device tree property?

This sort of configuration is typically done by:
   1. Creating a new 'caps' bit; relevant codepaths check that bit
   2. Creating a new "compatible" string for your platform's macb
      instance
   3. Creating a new 'struct macb_config' instance for your platform,
      setting any relevant caps bits when it is selected.

  Josh

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help