Re: [PATCH net-next v2 2/5] rhashtable: add function to replace an element

On Wed, Dec 09, 2015 at 10:43:23AM +0800, Herbert Xu wrote:

OK after thinking about it a little bit more I think your approach
is safe and we won't need to play any more games to get this to
work.  So I'm fine with this patch.

One suggestion though: your inline function doesn't actually
inline the fast path.  The only thing that's inlined is the loop
which is not that critical.  As this is probably not performance
critical how about just making the whole thing out-of-line?

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt