Re: [PATCH net] net: fix feature changes on devices without ndo_set_features
From: Jarod Wilson <hidden>
Date: 2015-11-13 14:34:32
From: Jarod Wilson <hidden>
Date: 2015-11-13 14:34:32
Nikolay Aleksandrov wrote:
From: Nikolay Aleksandrov<redacted>
When __netdev_update_features() was updated to ensure some features are
disabled on new lower devices, an error was introduced for devices which
don't have the ndo_set_features() method set. Before we'll just set the
new features, but now we return an error and don't set them. Fix this by
returning the old behaviour and setting err to 0 when ndo_set_features
is not present.
Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs")
CC: Jarod Wilson<redacted>
CC: Jiri Pirko<jiri@resnulli.us>
CC: Ido Schimmel<redacted>
CC: Sander Eikelenboom<redacted>
CC: Andy Gospodarek<redacted>
CC: Florian Fainelli<f.fainelli@gmail.com>
Signed-off-by: Nikolay Aleksandrov<redacted>
---
Sander please feel free to give your Tested-by.Ah, good catch, thank you for cleaning up my mess. Reviewed-by: Jarod Wilson <redacted> -- Jarod Wilson jarod@redhat.com