Thread (49 messages) 49 messages, 15 authors, 2016-04-02

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

From: Jiri Pirko <jiri@resnulli.us>
Date: 2015-11-13 14:00:29

Fri, Nov 13, 2015 at 02:54:01PM CET, razor@blackwall.org wrote:
From: Nikolay Aleksandrov <redacted>

When __netdev_update_features() was updated to ensure some features are
disabled on new lower devices, an error was introduced for devices which
don't have the ndo_set_features() method set. Before we'll just set the
new features, but now we return an error and don't set them. Fix this by
returning the old behaviour and setting err to 0 when ndo_set_features
is not present.

Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs")
CC: Jarod Wilson <redacted>
CC: Jiri Pirko <jiri@resnulli.us>
CC: Ido Schimmel <redacted>
CC: Sander Eikelenboom <redacted>
CC: Andy Gospodarek <redacted>
CC: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Nikolay Aleksandrov <redacted>
Reviewed-by: Jiri Pirko <redacted>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help