On (10/30/15 22:03), Nelson, Shannon wrote:

The more common idiom in our driver would be

	err = i40e_get_platform_mac_addr(..);
	if (err) {

Ok.

Have you tested this beyond a compile?
Do you have a DT model to try this against?

yes.

In looking at a couple other drivers, I see the difference being that
they typically are writing the primary mac filter on probe (and any
other reset), whereas the i40e "knows" that the default mac address is
already set up as the filter and doesn't bother with a redundant write.
If you want to add this Open Filter code, you'll need to arrange for
this write to happen.  You can't call i40e_set_mac() to do it, but you
can see the i40e_aq_mac_address_write() code there that is involved in
updating the mac address as an example.  You probably will want to look
at section 4.2.1.5.3 of the XL710 data sheet in order to know how to
use i40e_aq_mac_address_write() for your situation.

ok. I'll look into it (and also why this did not show up in my testing).

fwiw, the ixgbe patch is quite clearly missing in i40e, and hopefully
we wont be opportunistically fixing this one driver at a time in 
the future.

--Sowmini