Re: [PATCH 03/12] net: igb: avoid using timespec

From: Richard Cochran <richardcochran@gmail.com>
Date: 2015-10-02 07:47:27
Also in: intel-wired-lan, lkml
Reply to: Arnd Bergmann, 2015-10-01

On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote:

I tried to use this pattern whenever I convert the 64-bit 'long long'
tv_sec member of 'struct timespec64' into a 32-bit number, to annotate
the loss of range.

Sounds reasonable to me.

I have thought about defining separate helpers like this

...

This would make it even more explicit, but my fear was that I was
adding too much complexity like that.

I think a cast plus a comment when needed is clear enough.

Thanks,
Richard
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038

Arnd Bergmann · 2015-09-30
[PATCH 01/12] net: fec: avoid timespec use · Arnd Bergmann · 2015-09-30
Re: [PATCH 01/12] net: fec: avoid timespec use · Richard Cochran · 2015-10-01
[PATCH 08/12] nfnetlink: use y2038 safe timestamp · Arnd Bergmann · 2015-09-30
Re: [PATCH 08/12] nfnetlink: use y2038 safe timestamp · Pablo Neira Ayuso · 2015-10-02
Re: [PATCH 08/12] nfnetlink: use y2038 safe timestamp · Arnd Bergmann · 2015-10-02
[PATCH 09/12] ipv6: use ktime_t for internal timestamps · Arnd Bergmann · 2015-09-30
[PATCH 11/12] [RFC] ipv4: avoid timespec in timestamp computation · Arnd Bergmann · 2015-09-30
Re: [PATCH 11/12] [RFC] ipv4: avoid timespec in timestamp computation · kbuild test robot · 2015-09-30
Re: [Y2038] [PATCH 11/12] [RFC] ipv4: avoid timespec in timestamp computation · Arnd Bergmann · 2015-09-30
[RFC v2] ipv4: avoid timespec in timestamp computation · Arnd Bergmann · 2015-09-30
[RFC PATCH] ipv4: ktime_get_ms_of_day() can be static · kbuild test robot · 2015-09-30
Re: [PATCH 11/12] [RFC] ipv4: avoid timespec in timestamp computation · kbuild test robot · 2015-09-30
[PATCH 12/12] [RFC] can: avoid using timeval for uapi · Arnd Bergmann · 2015-09-30
Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi · Oliver Hartkopp · 2015-10-05
Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi · Arnd Bergmann · 2015-10-06
Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi · Marc Kleine-Budde · 2015-10-06
Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi · Arnd Bergmann · 2015-10-06
Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi · Marc Kleine-Budde · 2015-10-06
[PATCH 10/12] net: sctp: avoid incorrect time_t use · Arnd Bergmann · 2015-09-30
Re: [PATCH 10/12] net: sctp: avoid incorrect time_t use · Neil Horman · 2015-09-30
Re: [PATCH 10/12] net: sctp: avoid incorrect time_t use · Marcelo Ricardo Leitner · 2015-09-30
Re: [PATCH 10/12] net: sctp: avoid incorrect time_t use · Neil Horman · 2015-09-30
Re: [PATCH 10/12] net: sctp: avoid incorrect time_t use · Marcelo Ricardo Leitner · 2015-09-30
[PATCH 07/12] atm: hide 'struct zatm_t_hist' · Arnd Bergmann · 2015-09-30
Re: [PATCH 07/12] atm: hide 'struct zatm_t_hist' · Charles (Chas) Williams · 2015-09-30
Re: [PATCH 07/12] atm: hide 'struct zatm_t_hist' · Arnd Bergmann · 2015-09-30
[PATCH v2] atm: remove 'struct zatm_t_hist' · Arnd Bergmann · 2015-09-30
[PATCH 04/12] mwifiex: use ktime_get_real for timestamping · Arnd Bergmann · 2015-09-30
RE: [PATCH 04/12] mwifiex: use ktime_get_real for timestamping · Amitkumar Karwar · 2015-10-09
[PATCH 05/12] mwifiex: avoid gettimeofday in ba_threshold setting · Arnd Bergmann · 2015-09-30
RE: [PATCH 05/12] mwifiex: avoid gettimeofday in ba_threshold setting · Amitkumar Karwar · 2015-10-09
[PATCH 02/12] net: stmmac: avoid using timespec · Arnd Bergmann · 2015-09-30
Re: [PATCH 02/12] net: stmmac: avoid using timespec · Richard Cochran · 2015-10-01
[PATCH 03/12] net: igb: avoid using timespec · Arnd Bergmann · 2015-09-30
Re: [PATCH 03/12] net: igb: avoid using timespec · Richard Cochran · 2015-10-01
Re: [PATCH 03/12] net: igb: avoid using timespec · Arnd Bergmann · 2015-10-01
Re: [PATCH 03/12] net: igb: avoid using timespec · Richard Cochran · 2015-10-02
[PATCH 06/12] mac80211: use ktime_get_seconds · Arnd Bergmann · 2015-09-30
David Miller · 2015-10-05
View all 40 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help