Re: [PATCH 07/12] atm: hide 'struct zatm_t_hist'

From
Charles (Chas) Williams <3chas3@gmail.com>
Date
2015-09-30 15:24:41
Also in
lkml
Reply to
Arnd Bergmann, 2015-09-30
On Wed, 2015-09-30 at 13:26 +0200, Arnd Bergmann wrote:
The zatm_t_hist structure is not used anywhere in the kernel, but is
exported to user space. As we are trying to eliminate uses of time_t
in the kernel for y2038 compatibility, the current definition triggers
checking tools because it contains 'struct timeval'.

We can work around this by adding '#ifdef __KERNEL__'. I could not find
out what the structure is actually used for, so this is the safe choice
in case there is some user space tool that relies on the definition.

If we are sure that nothing in user space relies on the structure, we
can instead remove the definition completely.
It was used by the ZATM_GETHIST ioctl which is long since gone in the
kernel driver.  You can just remove this.
Thread (40 messages) 40 messages, 11 authors, last reply 2015-10-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help