Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

From
David Woodhouse <dwmw2@infradead.org>
Date
2015-09-23 18:41:54
Also in
linux-arm-kernel
Reply to
Jeremy Linton, 2015-08-12
On Wed, 2015-08-12 at 17:06 -0500, Jeremy Linton wrote:
quoted hunk ↗ jump to hunk

 
+static const struct acpi_device_id smsc911x_acpi_match[] = {
+       { "ARMH9118", 0 },
+       { }
+};
+MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match);
+
 static struct platform_driver smsc911x_driver = {
        .probe = smsc911x_drv_probe,
        .remove = smsc911x_drv_remove,
@@ -2661,6 +2656,7 @@ static struct platform_driver smsc911x_driver =
{
                .name   = SMSC_CHIPNAME,
                .pm     = SMSC911X_PM_OPS,
                .of_match_table = of_match_ptr(smsc911x_dt_ids),
+               .acpi_match_table = ACPI_PTR(smsc911x_acpi_match),
        },
 };
Hm, surely you shouldn't need this part? If the ACPI device has a HID
of PRP0001, and an appropriate "compatible" property, then it ought to
be loaded anyway. If that doesn't work, we should fix that.

-- 
dwmw2

Attachments

Thread (36 messages) 36 messages, 14 authors, last reply 2015-11-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help