Re: [PATCH 1/2] Add a matching set of device_ functions for determining mac/phy

On 08/12/2015 05:13 PM, Florian Fainelli wrote:

On 12/08/15 15:06, Jeremy Linton wrote:

quoted

+
+static void *device_get_mac_addr(struct device *dev,
+				 const char *name, char *addr,
+				 int alen)
+{
+	int ret = device_property_read_u8_array(dev, name, addr, alen);
+
+	if (ret == 0 && is_valid_ether_addr(addr))
+		return addr;
+	return NULL;

The DT counterpart has an additional check on the properly length to be
ETH_ALEN, you might want to have such check here for consistency and
correctness.

I will add it back,

Thanks,