RE: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board

From: David Miller <davem@davemloft.net> Sent: Friday, August 21, 2015 5:06 AM

To: Duan Fugang-B38611
Cc: shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org;
netdev@vger.kernel.org
Subject: Re: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb
board

From: Fugang Duan <redacted>
Date: Wed, 19 Aug 2015 13:33:58 +0800

quoted

The patch series is to add fec support for i.MX7d sdb board. Since
i.MX7d fec ip is the same as i.MX6SX, so there have no change for

driver itself.

quoted

Patch#1: add bcm54220 PHY ID entry into brcmphy.h file.

This is completely, and utterly, pointless.

The only reason a PHY ID should be defined in brcmphy.h is so that it can
be used in the broadcom.c PHY driver or similar.

If there is no user in the tree, there is no reason to add it to the
header file.

Ok, I will try to add the phy support in Broadcom phy driver. Thanks for your comment.

Regards,
Andy