Re: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2015-08-19 21:28:54
Also in:
linux-arm-kernel
2015-08-18 22:33 GMT-07:00 Fugang Duan [off-list ref]:
Add bcm54220 phy ID entry.
This change itself is fine, but looking at the rest of your changes, we are not adding an entry for this PHY in drivers/net/phy/broadcom.c, which means that we will bind to the Generic PHY driver, and so this looks sufficient, even with your fixup done in the subsequent patch.
quoted hunk ↗ jump to hunk
Signed-off-by: Fugang Duan <redacted> --- include/linux/brcmphy.h | 1 + 1 file changed, 1 insertion(+)diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index 697ca77..20bed15 100644 --- a/include/linux/brcmphy.h +++ b/include/linux/brcmphy.h@@ -16,6 +16,7 @@ #define PHY_ID_BCM5482 0x0143bcb0 #define PHY_ID_BCM5411 0x00206070 #define PHY_ID_BCM5421 0x002060e0 +#define PHY_ID_BCM54220 0x600d8589 #define PHY_ID_BCM5464 0x002060b0 #define PHY_ID_BCM5461 0x002060c0 #define PHY_ID_BCM54616S 0x03625d10 --1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-- Florian