Thread (3 messages) flat view 3 messages, 2 authors, 2015-08-14

Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

From: Adrien Schildknecht <hidden>
Date: 2015-08-14 07:04:20
Also in: linux-wireless, lkml

Hi,
On 08/14/2015 03:36 AM, Adrien Schildknecht wrote:
quoted
Both loops of this function compare data from the 'chan' array and
then check if the index is valid.

The 2 conditions should be inverted to avoid an out-of-bounds
access.
Was that found by a static analyzer or any other automated tool, or
was that the result of your very careful review?
The error has been reported by KASan:
==================================================================
BUG: KASan: out of bounds access in iwl_init_sband_channels+0x207/0x260 [iwlwifi] at addr ffff8800c2d0aac8
Read of size 4 by task modprobe/329
==================================================================

-- 
Adrien Schildknecht
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help