Thread (22 messages) 22 messages, 4 authors, 2015-09-02

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: David Miller <davem@davemloft.net>
Date: 2015-08-28 04:24:01

From: Cong Wang <redacted>
Date: Thu, 27 Aug 2015 18:49:09 -0700
On Thu, Aug 27, 2015 at 4:18 PM, David Miller [off-list ref] wrote:
quoted
From: Cong Wang <redacted>
Date: Thu, 27 Aug 2015 15:47:55 -0700
quoted
On Thu, Aug 27, 2015 at 3:42 PM, David Miller [off-list ref] wrote:
quoted
If you fix it properly, by making every qdisc capable of being ->init()'d
without explicit parameters, it will be the best behavior overall.
The problem is ->init() is not even called when setting it as default,
since setting a default qdisc doesn't need to create a qdisc. This is
why the flag has to be in ops->flags rather than qdisc->flags.
Just sounds like another shortcoming of how default qdiscs are handled,
It has to, due to its definition. I don't see any other way except we change
the meaning of the default qdisc.
We are talking past eachother.

If a default qdisc like HTB is choosen, we invoke the ->init() function
and we change the HTB ->init() function to do something reasonable
if a NULL set of configuration attributes is given.  ie. make HTB use
some defaults.

Please explain to me why this won't fix the problem.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help