Thread (22 messages) 22 messages, 4 authors, 2015-09-02

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang <hidden>
Date: 2015-08-27 22:47:56

On Thu, Aug 27, 2015 at 3:42 PM, David Miller [off-list ref] wrote:
Long term it's the wrong fix, trust me.
So we have plan to convert some non-defaultable qdisc to defaultable?
I don't see a reason here.
If you fix it properly, by making every qdisc capable of being ->init()'d
without explicit parameters, it will be the best behavior overall.
The problem is ->init() is not even called when setting it as default,
since setting a default qdisc doesn't need to create a qdisc. This is
why the flag has to be in ops->flags rather than qdisc->flags.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help